Repository navigation
core: build Welcome text from Core's Intro strings - #307
BenWestgate wants to merge 2 commits into
Conversation
The first-install Welcome dialog repeats Bitcoin Core's own first-run Intro dialog, but as a hand-kept copy that can drift from the Core release CipherStick installs. Read those strings from intro.ui and intro.cpp in the release source that is already authenticated against the signed SHA256SUMS, fill in Core's placeholders, and adapt only the two phrases that differ on Tails: the data stays in Persistent Storage, and CipherStick chooses the prune target. Every paragraph is kept. If a file is missing or any string has been reworded upstream, core-welcome-text prints nothing and install-core shows its existing built-in text, so a Core upgrade cannot produce a broken dialog. Refs #302
This comment has been minimized.
This comment has been minimized.
|
Generated by Claude Code |
Core's Intro phrases this sentence as "When you click OK, Bitcoin Core will begin to download". Keep CipherStick's existing "has begun to download" wording instead, so the generated dialog reads exactly like the built-in one, and fall back to the built-in text if Core rewords that sentence.
92ec061 to
ab9b3f7
Compare
|
cACK |
|
aNACK, this should not add LOC of to the project to grab the Core text. Prefer our own dialog and not building it from Core if it can't be done in fewer normal length readable LOC than presently. |
|
Understood. It can't be done in fewer lines than now. The built-in text is about 10 lines in
Even trimmed to the bone that's more lines than the text it replaces. This PR adds about 70 lines plus a test. Closing this in favour of keeping CipherStick's own dialog. #301 already does that and only adds the width fix. Generated by Claude Code |
Stacked on #224, which downloads the Bitcoin Core release source and authenticates it against the signed
SHA256SUMS.The first-install Welcome dialog repeats Bitcoin Core's own first-run Intro dialog, but as a hand-kept copy. This builds it from Core's strings in that authenticated source instead, so it follows the release CipherStick installs.
What changes
install-coreextractssrc/qt/forms/intro.uiandsrc/qt/intro.cppfrom the verified tarball, next to the files core: Authenticate pruning metadata #224 already extracts.core-welcome-textreads Core's Intro strings, fills in Core's placeholders (client name, sizes, 2009), and keeps CipherStick's wording in three places:install-coreshows its existing built-in text unchanged.Resulting text (pruned)
Not included: translations. Core's
.tsfiles are only partly translated, which would give a mixed-language dialog.Testing
tests/core-welcome-text.sh(new) passes. It uses small excerpts of Core's Intro strings as fixtures and covers pruned and unpruned text, singular "1 day", reworded upstream strings, missing files and bad input.intro.ui/intro.cppat master, v28.0 and v26.0.bitcoin-28.0.tar.gz, verified with itsSHA256SUMS.bash -nare clean.Refs #302
🤖 Generated with Claude Code
https://claude.ai/code/session_01LvEHMDeHvYQYDEkpJn95X8