Repository navigation
dock: put CipherStick first in Tails favorites - #308
Conversation
This comment has been minimized.
This comment has been minimized.
|
Generated by Claude Code |
2d591b6 to
cbaacf8
Compare
2f18946 to
57459c2
Compare
7ec12ea to
b90dfa7
Compare
bd5ecec to
2f0c420
Compare
38f7ae3 to
4b5a347
Compare
2f0c420 to
2954630
Compare
4b5a347 to
bfe0433
Compare
2954630 to
04430fd
Compare
bfe0433 to
7b28511
Compare
5b19963 to
4aa1f89
Compare
7b28511 to
0ebc2fb
Compare
4aa1f89 to
6fe9ff3
Compare
6fe8cf3 to
63c4436
Compare
6fe9ff3 to
67e034f
Compare
63c4436 to
955e5da
Compare
67e034f to
e2650ba
Compare
955e5da to
e110f68
Compare
e2650ba to
cc9973c
Compare
|
@codex review |
e110f68 to
4a20916
Compare
cc9973c to
eabdeb7
Compare
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
eabdeb7 to
d5e38b5
Compare
4a20916 to
09893f0
Compare
d5e38b5 to
9a99efb
Compare
13244dc to
10990a1
Compare
9a99efb to
e7315de
Compare
10990a1 to
8da30dc
Compare
e7315de to
99d09d9
Compare
8da30dc to
bb6b0ce
Compare
99d09d9 to
9d22cc6
Compare
CipherStick's login steps replaced GNOME's favorite-apps list with a hard-coded copy. Whenever Tails changed its defaults the copy went stale: Files disappeared from the dock, and Tails 7.6 replaced KeePassXC with Secrets, so the password manager vanished too. Read the current favorites and move CipherStick, Bitcoin Core and codex32 to the front, keeping every other entry as Tails or the user set it. No Tails app names are hard-coded, so later Tails releases need no change here. If the list cannot be read, leave the dock untouched. codex32 is included because stateless CryoStick users run it every session to recover keys for signing, and the three icons together introduce CipherStick when the Activities overview opens. Refs #240
bb6b0ce to
d98d33d
Compare
9d22cc6 to
5fb914a
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
LGTM, just consider renaming the .desktop for codex32 soon, it's very long
|
Thank you @PolymathBT for this bug report! it's because they replaced KeeppassXC with GNOME Secrets. That's also why strong passphrases were called weak! (I had called KeepassXC to estimate their entropy.) |
After setup, Tails apps disappear from the dock (reported in #240).
Stacked on #311, which replaces
wrappedwithcipherstick-login. This PR is one commit that changes the dock code there.Cause: the login steps replace GNOME's
favorite-appswith a hard-coded list. That copy goes stale whenever Tails changes its defaults:org.keepassxc.KeePassXC.desktop.Change: read the current favorites, then move CipherStick (
bails.desktop), Bitcoin Core (bitcoin-qt.desktop) and codex32 (io.github.benwestgate.codex32.desktop) to the front. Every other entry stays as Tails or the user set it.Testing (with
gsettingsmocked)@as []) gives just the CipherStick icons.bash -npass.Refs #240
🤖 Generated with Claude Code
https://claude.ai/code/session_01LvEHMDeHvYQYDEkpJn95X8