Repository navigation
Fix menu actions in the session that installs - #316
BenWestgate wants to merge 4 commits into
Conversation
|
The Generated by Claude Code |
|
cACK |
257501e to
35e6c76
Compare
|
I scanned every launch point and found one more first-session PATH gap. It's fixed in 35e6c76.
I rebased onto master for #294's menu change. The full list is in the PR description. Generated by Claude Code |
35e6c76 to
0ba3ae2
Compare
|
Generated by Claude Code |
0ba3ae2 to
0329c1c
Compare
💡 Codex ReviewBails/bails/.local/bin/core-dbcache Line 201 in 0329c1c Because ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The Codex finding is about Generated by Claude Code |
bb6b0ce to
d98d33d
Compare
0329c1c to
a0598ea
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
Codex current-head review at a0598ea: no findings. The first-session PATH gaps are handled at both launch points, and git -C guix.sigs fixes the cwd leak without changing the signed-release verification flow.
6850eb3 to
35f2b15
Compare
a0598ea to
e5e203a
Compare
|
Rebased onto #311's squashed commit (35f2b15). The old pre-squash #311 commits are dropped, and this branch's three commits applied cleanly. Tests pass. Once #311 merges, only the three menu commits will be left. Generated by Claude Code |
35f2b15 to
9ed40bc
Compare
e5e203a to
4362785
Compare
|
Rebased again, this time onto #311's amended commit 9ed40bc. Tests pass. Generated by Claude Code |
05ed878 to
4dfdc4f
Compare
2178162 to
b171457
Compare
4362785 to
d5c8962
Compare
This comment has been minimized.
This comment has been minimized.
|
I rebased onto #311's current head (b171457) and pushed d5c8962. The diff is still only the three fixes, with no conflicts. I re-checked the launchers on the new head. The supported-Tails end-to-end check is still open, since this container can't run Tails. It needs a real Tails boot: install, then from the menu without a reboot, open codex32 and run Update Bitcoin Core. Generated by Claude Code |
5853259 to
44489b8
Compare
Bitcoin Core's own login autostart raced CipherStick's login steps, so Core could start before its session config existed, and a dbcache sized from one computer's RAM had to be kept out of Persistent Storage. A restart state machine to repair that race made the change hard to review. Run one login autostart, cipherstick.desktop. Its script asks cryostick whether this is a CryoStick, activates the needed Persistent Storage features, writes the RAM-only session config, then starts Bitcoin Core. CryoSticks skip the Tor reminder and chainstate preload, since they stay offline. Updates delete wrapped, cipherstick-login and the old Core and CryoStick autostarts. core-config writes the session config, core-dbcache adds a large dbcache only while the node is more than 14 days behind and records the tip, and core-prune keeps the template's prune target fitting the stick. settings.json is left to Core. Fixes #58 and #253.
44489b8 to
4d46d75
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
In the Tails session that installs CipherStick, ~/.local/bin did not exist at login, so the desktop session's PATH lacks it. Opening codex32 from the menu before rebooting then fails to run bitcoin-cli and says Bitcoin Core is unavailable while Core is running. The python-codex32 GUI also looks bitcoin-cli up on PATH. Add ~/.local/bin when missing. Bitcoin Core also stays in RPC warmup while one of its startup messages waits for an answer, such as the oversized dbcache warning fixed by #310. Say so in the unavailable dialog, since bitcoin-qt starts minimized and the message is easy to miss.
When a Console window is already open, kgx hands the command to that window's process, which runs it with its own PATH instead of the menu's. A Console opened in the session that installed CipherStick has no ~/.local/bin on PATH, so "Update Bitcoin Core" could not find install-core. Checked with gnome-console 46 on a test display: the second window got the first window's PATH.
When guix.sigs is already there from an earlier install, install-core changed into it to pull and never changed back. builder-keys and the bitcoin-core-VER download folder were then looked for in the wrong place, so every "Update Bitcoin Core" failed with "cd: bitcoin-core-VER: No such file or directory". Pull with git -C instead.
d5c8962 to
7797403
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
AI current-head review: ACK 7797403. The three changes directly address first-session integration failures without widening behavior: the menu invokes install-core by absolute user-bin path, install-core updates guix.sigs without leaking its working directory, and open-codex32 repairs the login-session PATH before probing Core. Existing threads are resolved and exact-head lint CI is green. No finding.
5b2e2fc to
3e95d57
Compare
Requested by Ben · project thread
Stacked on #311, which removes
wrapped. Merge #311 first; GitHub then retargets this PR to master.Before: in the Tails session that installed CipherStick, opening codex32 from the menu says "Bitcoin Core unavailable" while Core is running. "Update Bitcoin Core" can't find
install-coreif a Console window is open. "Update Bitcoin Core" also fails after any first install withcd: bitcoin-core-VER: No such file or directory.After: all three work without a restart.
How
open-codex32: adds~/.local/binto PATH when it's missing. That session logged in before the folder existed, and the python-codex32 GUI also findsbitcoin-clithrough PATH. The unavailable dialog now also says that an open Core message blocks startup.bails-menu: runs install-core by full path. When a Console window is already open,kgx -- cmdruns the command in that window's process with that process's PATH. I checked this with gnome-console 46.install-core: pulls guix.sigs withgit -Cinstead ofcd-ing into it and never changing back. Master has the same bug.Scan, on top of #311 (fake-Tails, real Core 32.0rc2)
I ran a full install of this branch, then ran every launch path with the menu session's PATH, without
~/.local/bin:core-startedthroughstartupnotify.Nothing was missing on this branch, and the Core update completed and restarted Core. On #311 alone, the codex32 Core check fails because it can't find
bitcoin-cli. #311 already has the PATH guard inbails-menuandcore-started, and it givesstartupnotifya full path. Autostart andbsource~/.profile.Testing
tests/open-codex32-core.shandtests/core-dbcache.shpass.bails-menuandinstall-core.open-codex32shows only the SC2119/SC2120 notes it already had.🤖 Generated with Claude Code
https://claude.ai/code/session_01CUXR1M1FCGzuX6J6qAzrjo