Repository navigation
reviewability: restore the <5000 installed-package budget on the integrated v1 tree #61
Description
Activity
- addedgate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.Resolve, merge, or explicitly defer before the next full adversarial review.area: wallet/coreWallet integration and Bitcoin Core boundaries.Wallet integration and Bitcoin Core boundaries.area: correctionCorrection engine and correction UX.Correction engine and correction UX.area: cliCommand-line interface behavior.Command-line interface behavior.bugSomething isn't workingSomething isn't workingarea: packaging/releasePackaging, artifacts, compatibility, and release qualification.Packaging, artifacts, compatibility, and release qualification.
on Sep 28, 2026 Sizing follow-up: #53 is only +4 logical package lines versus current
reviewability-v1; #23/#52 do not materially add production package code. The present integrated estimate is therefore about 5,102 before #53's planned shared ASCII-helper deduplication.The GUI does not count against this cap: it is a separate
src/codex32_guipackage with its own enforced<2000budget. Current heads measure 1,983 lines for #28 and the preflighted #10+#28 combination is 1,997. So #61 is specifically a roughly 100-line library/CLI review-surface problem.BenWestgate commented
on Sep 28, 2026 OwnerAuthorMore actionsMaintainer decision on 2026-09-28 supersedes this issue's earlier “do not raise the threshold” condition: the authorized v1 installed-package cap is now
<5200, specifically to avoid a riskier pre-release refactor whose only purpose would be shaving ~100 already-reviewed lines. PR #62 is the focused policy/enforcement change and is green. Keep this issue open until #62 lands; no production refactor is required to close it.
A disposable integration from
reviewability-v126f933eexposed a release-gate failure that individual PR CI cannot see.Current logical review-line counts (nonblank, non-comment
src/codex32/**/*.py, matchingtest_production_size_budgets_are_enforced):26f933e: 4,893docs/developer/api.mdrequires the installed v1 package to remain below 5,000 lines and says changing that budget requires explicit review and authorization. Do not raise the threshold as part of this issue.Acceptance:
<5000without weakening correct: Interpret mixed-case damage #42 mixed-case correction or wallet: Require the recorded fingerprint before import #57 verify-before-mutate / wallet-record behavior;The disposable integration worktree only produced local synthetic commits; no project branch was changed.