Skip to content

reviewability: restore the <5000 installed-package budget on the integrated v1 tree #61

Description

@BenWestgate

A disposable integration from reviewability-v1 26f933e exposed a release-gate failure that individual PR CI cannot see.

Current logical review-line counts (nonblank, non-comment src/codex32/**/*.py, matching test_production_size_budgets_are_enforced):

docs/developer/api.md requires the installed v1 package to remain below 5,000 lines and says changing that budget requires explicit review and authorization. Do not raise the threshold as part of this issue.

Acceptance:

  • reduce the integrated production tree to <5000 without weakening correct: Interpret mixed-case damage #42 mixed-case correction or wallet: Require the recorded fingerprint before import #57 verify-before-mutate / wallet-record behavior;
  • keep the cleanup focused on real review-surface reduction, not formatting compression or moving live runtime code outside the counted package;
  • rerun the exact production-size test on the combined tree plus normal/optimized tests covering touched paths;
  • fold the final result into the one-time post-prerequisite cleanup refresh before the frozen adversarial-review candidate is declared.

The disposable integration worktree only produced local synthetic commits; no project branch was changed.

Activity

  1. added
    gate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.
    area: wallet/coreWallet integration and Bitcoin Core boundaries.
    area: correctionCorrection engine and correction UX.
    area: cliCommand-line interface behavior.
    bugSomething isn't working
    area: packaging/releasePackaging, artifacts, compatibility, and release qualification.
    on Sep 28, 2026
  2. BenWestgate commented on Sep 28, 2026

    @BenWestgate
    OwnerAuthor

    Sizing follow-up: #53 is only +4 logical package lines versus current reviewability-v1; #23/#52 do not materially add production package code. The present integrated estimate is therefore about 5,102 before #53's planned shared ASCII-helper deduplication.

    The GUI does not count against this cap: it is a separate src/codex32_gui package with its own enforced <2000 budget. Current heads measure 1,983 lines for #28 and the preflighted #10+#28 combination is 1,997. So #61 is specifically a roughly 100-line library/CLI review-surface problem.

  3. BenWestgate commented on Sep 28, 2026

    @BenWestgate
    OwnerAuthor

    Maintainer decision on 2026-09-28 supersedes this issue's earlier “do not raise the threshold” condition: the authorized v1 installed-package cap is now <5200, specifically to avoid a riskier pre-release refactor whose only purpose would be shaving ~100 already-reviewed lines. PR #62 is the focused policy/enforcement change and is green. Keep this issue open until #62 lands; no production refactor is required to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliCommand-line interface behavior.area: correctionCorrection engine and correction UX.area: packaging/releasePackaging, artifacts, compatibility, and release qualification.area: wallet/coreWallet integration and Bitcoin Core boundaries.bugSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions