docs(vault): document separate login and secret namespaces - #1511
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Open
7 tasks
Contributor
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bf206a5. Configure here.
…ence Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the two new HashiCorp Vault settings that split the Vault Enterprise namespace used for AppRole and TLS cert login (
HCP_VAULT_LOGIN_NAMESPACE, sent as theX-Vault-Namespaceheader) from the namespace used for secret reads, writes, rotates and deletes (HCP_VAULT_SECRET_NAMESPACE, a URL path segment). Both fall back toHCP_VAULT_NAMESPACE, so the page keeps the single-variable example as the default and adds a "Namespaces" section with a worked example for the customer's shape: a role defined in a parent namespace that logs in there and manages keys and provider secrets under a team namespace. The per-teamnamespaceoverride bullet now says it replaces the secret namespace in the URL and never affects login, which matches what the code does after the companion litellm change. The env var reference table indocs/proxy/config_settings.mdgains a row for each new variable, next to the existingHCP_VAULT_*rows, which is also what the litellm repo'sdocumentationandcode-qualitychecks read to confirm everyos.getenvkey is documentedCompanion code change: BerriAI/litellm branch
litellm_vault_login_secret_namespace(LIT-1983)Proof
npm run buildexits 0 and the rendered page shows the new sectionLinear ticket
Resolves LIT-1983
Link to Devin session: https://app.devin.ai/sessions/798e6e6460fc40deb35c1219944662cf
Open in Devin Desktop: https://app.devin.ai/desktop/session/798e6e6460fc40deb35c1219944662cf?variant=devin
Requested by: @yassin-berriai
Note
Low Risk
Documentation-only updates with no runtime or security behavior changes in this repository.
Overview
Documents split Vault Enterprise namespaces for HashiCorp Vault: optional
HCP_VAULT_LOGIN_NAMESPACE(AppRole/TLS login viaX-Vault-Namespace) andHCP_VAULT_SECRET_NAMESPACE(secret URL path segment), both defaulting toHCP_VAULT_NAMESPACEso existing setups stay valid.The Step 1 env example and a new Namespaces section explain when to use each setting, including a parent-namespace login + team secret path example and Admin UI field names. The team JSON override for
namespaceis updated to describe secret URL namespace only (not login).Reviewed by Cursor Bugbot for commit bf206a5. Bugbot is set up for automated code reviews on this repo. Configure here.