Conversation
- add basis rule and crossfield rules - add type-helper rules
Contributor
There was a problem hiding this comment.
Code Review
이번 풀리퀘스트는 스키마 검증을 위한 다양한 신규 규칙(기본 규칙, 교차 필드 참조 규칙, 타입 헬퍼 배치 규칙 및 @each 사용 규칙)과 관련 테스트 코드를 추가합니다. 이를 위해 데코레이터가 실행 인자(args)를 캡처하여 저장하도록 수정되었으며, FieldState 구조에 sourceKey와 siblingFields가 추가되었습니다. 리뷰 피드백에서는 packages/express-cargo/src/rules/crossField.ts 파일 내에서 발생할 수 있는 런타임 에러를 방지하기 위해 applied.args?.[0]과 같이 옵셔널 체이닝을 적용할 것을 권장하고 있습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
laggu
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p1에 해당하는 데코레이터 검증 규칙을 추가합니다.
@With,@Without의 대상 필드가 없는 경우 거부@Each를 적용한 경우 거부@List를 적용한 경우 거부@Type를 적용한 경우 거부