Merged
Conversation
d924f69 to
80243f8
Compare
Contributor
Ranjna-G
reviewed
Mar 3, 2026
Ranjna-G
reviewed
Mar 3, 2026
Ranjna-G
reviewed
Mar 3, 2026
Ranjna-G
reviewed
Mar 3, 2026
80243f8 to
a8f5e6e
Compare
abhishekagrawal080
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-133
Description
Recovery transactions for ADA wallets holding native tokens were dropping
the tokens entirely, producing only a single ADA output instead of the
expected token output + ADA remainder output.
Root cause: 'recover()' function in 'ada.ts' called 'changeAddress()' without
passing the token asset list from the UTXO set, so the transaction builder
had no knowledge of tokens. Additionally, the 'buildImplementation()' gate
in 'transactionBuilder.ts' did not route token recovery into the refactored
build path ('processTokenBuild') which handles token outputs correctly.
Fix:
fingerprint-keyed map and pass it as the 3rd argument to 'changeAddress()'
non-empty, so the builder routes through 'processTokenBuild()' →
'addChangeOutput()' which produces both a token output (1.5 ADA + tokens)
and an ADA remainder output
Issue Number
CSHLD-133
Type of change
How Has This Been Tested?
Added two unit tests in
test/unit/ada.ts:correct token quantity/policy) and one ADA remainder output (totalBalance - minADA - fee)
Ran locally with:
npx mocha
All the 160 test cases passed.