Getblocktemplate broken in v 0.1.10

[laakie]

./BGL-cli getblocktemplate '{"rules": ["segwit"]}'
error code: -1
error message:
basic_string::_M_construct null not valid

Compiled from source ( After fixing some configure errors.... )

[naftalimurgor]

What Os version are you on? I'd like to:

• Reproduce this
• Debug
• Submit bug fix and a corresponding unit test

[naftalimurgor]

still experiencing this issue?

Got it building on Ubuntu 22.04 (gcc 11.3.0)

[laakie]

Not able to build most if the versions from source.
They all have a ton of errors.
Running 0.1.8, it's the only version that I managed to compile after a few tweaks

[naftalimurgor]

It would be great to provide:

• clang or gcc?
• What versions?
• OS version?
  Thanks

[laakie]

All other versions then 0.1.8
Ubuntu 20.04, and 22.04
Gcc 9,10,11

[janus]

All other versions then 0.1.8 Ubuntu 20.04, and 22.04 Gcc 9,10,11

I look into this issue. Just give me some time.

[naftalimurgor]

All other versions then 0.1.8
Ubuntu 20.04, and 22.04
Gcc 9,10,11

I'll check with those versions and give you feedback soon.

[janus]

Not able to build most if the versions from source. They all have a ton of errors. Running 0.1.8, it's the only version that I managed to compile after a few tweaks

They all have a ton of errors.
Please what is the configuration that you used? I would like to fix the errors.

[gitcoindev]

Hi @janus , @naftalimurgor , @van-orton I am able to reproduce this bug.

I finally discovered build errors as well - 0.1.10 tag is broken and the build was fixed at later commit in release-0.1.10 branch.

Master branch getblocktemplate works fine, both gcc and clang:

'{"rules": ["segwit"]}'
{
  "capabilities": [
    "proposal"
  ],
  "version": 536870912,
  "rules": [
    "csv",
    "!segwit",
    "taproot"
  ],
  "vbavailable": {
  },
  "vbrequired": 0,
  "previousblockhash": "2e14eaec9745ec9690602feddf650eb6e436d32a3ae8453cf6a90ef1d53a6c42",
  "transactions": [
  ],
  "coinbaseaux": {
  },
  "coinbasevalue": 20000000000,
  "longpollid": "2e14eaec9745ec9690602feddf650eb6e436d32a3ae8453cf6a90ef1d53a6c422",
  "target": "dfff000000000000000000000000000000000000000000000000000000000000",
  "mintime": 1585958401,
  "mutable": [
    "time",
    "transactions",
    "prevblock"
  ],
  "noncerange": "00000000ffffffff",
  "sigoplimit": 80000,
  "sizelimit": 400000,
  "weightlimit": 400000,
  "curtime": 1690895708,
  "bits": "2100dfff",
  "height": 1,
  "default_witness_commitment": "6a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9"
}

whereas 0.1.10 release build returns the following error:

error code: -1
error message:
basic_string::_M_construct null not valid

I went through a quite entertaining debugging session with GDB and was able to find the root cause and the commit that introduced the change. VersionBitsDeploymentInfo contains null value for the taproot.

Thread 22 "b-httpworker.3" hit Breakpoint 6, gbt_vb_name (pos=Consensus::DEPLOYMENT_TAPROOT) at rpc/mining.cpp:495
495	    const struct VBDeploymentInfo& vbinfo = VersionBitsDeploymentInfo[pos];
(gdb) p VersionBitsDeploymentInfo
$9 = {{name = 0x55656fc0a2ac "testdummy", gbt_force = true}, {name = 0x55656fc0a2b6 "taproot", gbt_force = true}, {name = 0x0, gbt_force = false}}
(gdb) 

I already have a fix that works for me locally, I will submit a PR asap.

[gitcoindev]

PR with the fix opened #128

[janus]

Hi @janus , @naftalimurgor , @van-orton I am able to reproduce this bug.

I finally discovered build errors as well - 0.1.10 tag is broken and the build was fixed at later commit in release-0.1.10 branch.

Master branch getblocktemplate works fine, both gcc and clang:

'{"rules": ["segwit"]}'
{
  "capabilities": [
    "proposal"
  ],
  "version": 536870912,
  "rules": [
    "csv",
    "!segwit",
    "taproot"
  ],
  "vbavailable": {
  },
  "vbrequired": 0,
  "previousblockhash": "2e14eaec9745ec9690602feddf650eb6e436d32a3ae8453cf6a90ef1d53a6c42",
  "transactions": [
  ],
  "coinbaseaux": {
  },
  "coinbasevalue": 20000000000,
  "longpollid": "2e14eaec9745ec9690602feddf650eb6e436d32a3ae8453cf6a90ef1d53a6c422",
  "target": "dfff000000000000000000000000000000000000000000000000000000000000",
  "mintime": 1585958401,
  "mutable": [
    "time",
    "transactions",
    "prevblock"
  ],
  "noncerange": "00000000ffffffff",
  "sigoplimit": 80000,
  "sizelimit": 400000,
  "weightlimit": 400000,
  "curtime": 1690895708,
  "bits": "2100dfff",
  "height": 1,
  "default_witness_commitment": "6a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9"
}

whereas 0.1.10 release build returns the following error:

error code: -1
error message:
basic_string::_M_construct null not valid

I went through a quite entertaining debugging session with GDB and was able to find the root cause and the commit that introduced the change. VersionBitsDeploymentInfo contains null value for the taproot.

Thread 22 "b-httpworker.3" hit Breakpoint 6, gbt_vb_name (pos=Consensus::DEPLOYMENT_TAPROOT) at rpc/mining.cpp:495
495	    const struct VBDeploymentInfo& vbinfo = VersionBitsDeploymentInfo[pos];
(gdb) p VersionBitsDeploymentInfo
$9 = {{name = 0x55656fc0a2ac "testdummy", gbt_force = true}, {name = 0x55656fc0a2b6 "taproot", gbt_force = true}, {name = 0x0, gbt_force = false}}
(gdb) 

I already have a fix that works for me locally, I will submit a PR asap.

Great job!

[gitcoindev]

Hi! I see my five pull requests have stalled for the last weeks. I still have some resources to help solve any issue that you think would be helpful to push the project forward. Is there anything to work on or would you like me to rework anything @janus @naftalimurgor @van-orton @wu-emma ?