dynamic array solved

[shubhamdagar9854]

Features:
✅ Append – Add elements to the end of the array
✅ Insert – Add elements at a specific index
✅ Get & Set – Access or update elements by index
✅ Remove – Delete elements from the array
✅ Resizing – Doubles capacity when full, shrinks when needed
✅ Iterator Support – Allows iteration over elements

#28

Summary by Sourcery

Implement a custom Dynamic Array data structure in Python with dynamic resizing and core array operations

New Features:

• Create a DynamicArray class that supports dynamic resizing, element manipulation, and iteration

Enhancements:

• Implement efficient array operations with amortized O(1) append and O(1) access time
• Add iterator support for easy traversal of array elements

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a DynamicArray class in Python, providing a dynamic array implementation with resizing capabilities. The implementation includes methods for appending, inserting, getting, setting, and removing elements, as well as resizing the array when necessary. It also supports iteration and provides basic utility methods like size, is_empty, and clear.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Implemented the core dynamic array functionality, including initialization, resizing, and basic operations.	Implemented the __init__ method to initialize the array with a default capacity of 2. Implemented the _make_array method to create a low-level array using ctypes. Implemented the _resize method to double the array's capacity when full or halve it when mostly empty. Implemented the append method to add elements to the end of the array. Implemented the insert method to insert elements at a specific index, shifting existing elements. Implemented the get method to retrieve elements at a given index. Implemented the set method to update elements at a given index. Implemented the remove method to remove elements at a given index, shifting subsequent elements. Implemented the size method to return the number of elements in the array. Implemented the is_empty method to check if the array is empty. Implemented the clear method to reset the array to its initial state.	dynamic_array.py
Added iterator support and a string representation for easy inspection.	Implemented the __iter__ method to allow iteration over the elements in the array. Implemented the __str__ method to provide a string representation of the array's contents.	dynamic_array.py
Included a basic usage example within the if __name__ == '__main__': block.	Added a demonstration of the DynamicArray class, showcasing append, insert, and remove operations.	dynamic_array.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @shubhamdagar9854 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a pop method to remove and return the last element of the array.
• The resizing logic could be improved to prevent excessive resizing when removing elements.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (performance): Reconsider the fixed reset capacity in clear.

Resetting the array to a capacity of 2 after clearing might not be ideal if the array was previously resized to a much larger capacity. Depending on expected usage, preserving the current capacity or allowing it to be configurable could reduce future resizes.

Suggested change

	def clear(self):
	"""Clears the array by resetting all elements."""
	self._n = 0
	self._capacity = 2
	self._array = self._make_array(self._capacity)
	def clear(self):
	"""Clears the array by resetting all elements while preserving the current capacity."""
	self._n = 0
	self._array = self._make_array(self._capacity)