ERC-721 NFT + English Auction assignment#5
Open
Valreb001 wants to merge 1 commit into
Open
Conversation
SimpleNFT: standard ERC-721 with owner-only mint, custom errors, and correct revert-on-nonexistent-token behavior. EnglishAuction: list/bid/ settle/withdraw with a pending-returns fallback so a griefing bidder can't lock the auction. Deployed and verified on Sepolia (addresses in README). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Mac-5
self-requested a review
July 16, 2026 06:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleNFT) written from scratch: owner-only mint, custom errors, correct revert-on-nonexistent-token behavior, bothsafeTransferFromoverloads with theonERC721Receivedcheck.EnglishAuction: list (via approve + transferFrom) / bid / settle / withdraw, with a pending-returns fallback so a griefing bidder can't lock the auction.forge fmt --checkclean.Test plan
forge buildforge test -vv(33/33 passing)forge fmt --checkcast call(ownerOf, auction state)🤖 Generated with Claude Code