ERC-721 Token + English Auction (Foundry)#8
Open
levoski1 wants to merge 2 commits into
Open
Conversation
Mac-5
self-requested a review
July 16, 2026 09:49
Mac-5
requested changes
Jul 16, 2026
|
|
||
| constructor(IERC721 _nft, uint256 _tokenId, uint256 _reservePrice, uint256 _duration) { | ||
| seller = msg.sender; | ||
| nft = _nft; |
Collaborator
There was a problem hiding this comment.
So you are to expect the address of the nft refactor to use the address and typecast with your import interface
constructor(address _nft,) {
nft = IERC721(_nft);
}| endTime = block.timestamp + _duration; | ||
| } | ||
|
|
||
| modifier onlySeller() { |
| _; | ||
| } | ||
|
|
||
| function bid() external payable auctionActive { |
Collaborator
There was a problem hiding this comment.
follow CEI for this function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERC-721 Token + English Auction (Foundry)
@Mac-5