Skip to content

fix: correctness and hygiene fixes on released simplicityhl 0.6.0 - #7

Merged
KyrylR merged 1 commit into
masterfrom
chore/cleanup
Jul 27, 2026
Merged

fix: correctness and hygiene fixes on released simplicityhl 0.6.0#7
KyrylR merged 1 commit into
masterfrom
chore/cleanup

Conversation

@KyrylR

@KyrylR KyrylR commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator
  1. Optimized (reduced features) tokio
  2. Reduced binary size (builde time increased)
  3. find_function_call_context and extract_function_name scanned with a character counter but sliced the line by byte offset (line.len() - 1 - i).
  4. fixed did_change indexed content_changes[0], which panics on the empty change
      list some clients send
  5. did_close was an empty stub, so a closed file kept its diagnostics displayed in the editor
  6. on_change analysed without the lock and then wrote unconditionally.

Hygiene:

  • Removed the unused LspError::DocumentNotFound variant. Code 4 is left unallocated so the remaining error codes stay stable.

@KyrylR
KyrylR requested a review from gerau July 27, 2026 11:25

@gerau gerau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3c251e; code review

@KyrylR
KyrylR merged commit 554cba5 into master Jul 27, 2026
9 checks passed
@KyrylR
KyrylR deleted the chore/cleanup branch July 27, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants