general: support 0.7 compiler version - #9
Merged
Conversation
Collaborator
Author
|
tagged and published a |
KyrylR
force-pushed
the
feature/minimal-imports-enums
branch
from
July 28, 2026 11:42
6cb8bd4 to
50d3790
Compare
gerau
reviewed
Jul 28, 2026
Comment on lines
+921
to
+924
| // This merged backend owns one open document at a time. Compiler 0.7 | ||
| // diagnostics can point into imported files; | ||
| // TODO: until multi-document publication is implemented, keep those visible on the | ||
| // root document without pretending their byte offsets belong to the root source. |
Collaborator
There was a problem hiding this comment.
not sure if I properly understand, but it is implemented -- we need to group diagnostics by Uri and loop at the end of the function to push diagnostics in each file
Collaborator
Author
There was a problem hiding this comment.
It is, but to keep this PR simple it will be resolved in follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for enums, migrate to the new span logic