tty: restore cursor when stopped#694
Merged
jkloetzke merged 1 commit intoBobBuildTool:masterfrom Jan 19, 2026
Merged
Conversation
If the user presses Ctrl+Z on the terminal, the kernel will send SIGTSTP to the current foreground process group. By default, this will directly stop all processes. But if we have messed with the terminal (e.g. disabled cursor), this will leave the terminal in a barely usable state. Fix that by handling SIGTSTP and restore the original tty settings. If that is done, we can stop ourself. Upon resumption, re-initialize the tty and carry on.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 89.28% 89.25% -0.03%
==========================================
Files 50 50
Lines 16422 16443 +21
==========================================
+ Hits 14662 14676 +14
- Misses 1760 1767 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user presses Ctrl+Z on the terminal, the kernel will send SIGTSTP to the current foreground process group. By default, this will directly stop all processes. But if we have messed with the terminal (e.g. disabled cursor), this will leave the terminal in a barely usable state.
Fix that by handling SIGTSTP and restore the original tty settings. If that is done, we can stop ourself. Upon resumption, re-initialize the tty and carry on.