Skip to content

Conversation

@jkloetzke
Copy link
Member

The validation of internal settings already produces proper schema exceptions if errors are found. We must not cat these exceptions but propagate them, though.

Likewise, allow external plugins to throw schema.SchemaError exceptions. In case the validate() function returns false, throw the exception ourselves.

Fixes #696.

The validation of internal settings already produces proper schema
exceptions if errors are found. We must not cat these exceptions but
propagate them, though.

Likewise, allow external plugins to throw schema.SchemaError exceptions.
In case the validate() function returns false, throw the exception
ourselves.

Fixes BobBuildTool#696.
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (a7e2791) to head (b461023).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pym/bob/input.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          50       50           
  Lines       16443    16446    +3     
=======================================
+ Hits        14676    14679    +3     
  Misses       1767     1767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkloetzke jkloetzke merged commit ca1f5e7 into BobBuildTool:master Feb 10, 2026
11 checks passed
@jkloetzke jkloetzke deleted the improve-validation-errors branch February 10, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong error message shown

1 participant