[WIP] Add multiple select type min and max configuration constrain#21
[WIP] Add multiple select type min and max configuration constrain#21julian-ladjani wants to merge 7 commits intoBrille24:masterfrom
Conversation
…nslation, fix select type configuration error
mamazu
left a comment
mamazu
left a comment
There was a problem hiding this comment.
First of all thanks for your contribution. There are just some minor things to add.
Please run our codestyle formatter (yeah we have our own guidelines). This will reduce the amount of changes.
Second, it would be great if you could add some tests for the new constraints in the constraint creator and Behat tests for checking that the constraints are working would be great.
|
I have a problem with database saving, It save default values no edited values in form, I don't know why |
|
If you introduce a new constraint you need to manually upgrade the database fields for this type otherwise it will not work. Or just delete and recreate the customer options that are buggy. |
|
It's not that, options "multi select" just save default values of configuration not edited values |
|
Is the field in the form type correctly named? |
mamazu
force-pushed
the
master
branch
2 times, most recently
from
a47f652 to
783f161
Compare
2 participants
No description provided.