[BCMS-926] Fixes timeout handling for wider compatibility#127
Merged
Conversation
Removes the check for the `this` context during Butter class instantiation, directly returning a new instance. This simplifies the instantiation process, and should result in new instances each time this is called in Node so that we respect user set timeouts
Addresses an issue where the timeout was not properly cleared in React Native and Node.js environments when using a regular timeout (instead of AbortSignal.timeout). Updates the code to ensure the timeout is cleared by saving the timeout ID and clearing it after use, preventing potential memory leaks or unexpected behavior.
ViolanteCodes
approved these changes
Sep 4, 2025
ViolanteCodes
left a comment
ViolanteCodes
left a comment
Contributor
There was a problem hiding this comment.
This LGTM - looks the exact same as the two reverted commits
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It re-applies #124 with proper conventions for commit messages (which allows automatic publish to run).
https://tiugotech.atlassian.net/browse/BCMS-926