Don't merge: Test new fingerprinting - #1312
Closed
edopao wants to merge 16 commits into
Closed
Conversation
Contributor
Author
|
cscs-ci run dace |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run dace |
edopao
force-pushed
the
test-fingerprinting-tree-cata
branch
from
June 17, 2026 10:18
a998a10 to
d8334b5
Compare
Contributor
Author
|
cscs-ci run default |
1 similar comment
Contributor
Author
|
cscs-ci run default |
edopao
force-pushed
the
test-fingerprinting-tree-cata
branch
from
June 17, 2026 16:49
b2e541c to
a0dccf3
Compare
edopao
force-pushed
the
test-fingerprinting-tree-cata
branch
from
June 17, 2026 16:51
a0dccf3 to
3887d68
Compare
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
GT4Py PR 2411 (in the 1.1.11 line) narrows OffsetProviderElem to neighbor-tables only, so the `Koff -> KDim` Dimension entry injected into every grid's offset provider is rejected at compile()/call time on gtfn. The intended replacement is inline vertical shifts `field(KDim +/- i)`, which need no offset-provider entry. This migrates all static `Koff[i]` shifts to `KDim +/- i` (49 stencil files), drops the `Koff -> KDim` workaround in grid/base.py and its dead `size` branch, and removes the now-unneeded `"Koff": dims.KDim` entries from explicit offset_provider call sites in src and tests. Dynamic `as_offset(Koff, ...)` offsets are left unchanged. NOTE: requires gt4py >= 1.1.11 (PR 2411). On plain 1.1.10 the KDim+/-i syntax does not compile on gtfn; do not merge until the gt4py bump lands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
Contributor
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
Contributor
Author
|
GT4Py PR i merged, closing this test PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #1327