Skip to content

Conversation

@Vasist10
Copy link
Contributor

@Vasist10 Vasist10 commented Dec 26, 2025

Description

Added cycle detection to prevent task dependency loops (e.g., Task A → Task B → Task A).

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Screenshot 2025-12-28 150247

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@Vasist10
Copy link
Contributor Author

Vasist10 commented Dec 28, 2025

the latest 3 commits fix:

  • Improve the toast message to make to more clearer from a generic message
  • Fix an issue where a task involved in a circular dependency still appeared in the UI even after the backend rejected the update, until a manual sync was triggered.
    ex:
    In this below image the task 'panic' forms a circular dependency with task 'panib' and task 'pania'.....but still even after the backend rejects the dependency the task 'panic' is appearing in the frontend(until sync was applied).
Screenshot 2025-12-28 120833

this ui buggy behavior is fixed now

@Vasist10
Copy link
Contributor Author

@its-me-abhishek i have added the self review and fixed the ui buggy behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular dependency in task dependencies

2 participants