Skip to content

style: improve bottom sheet keyboard behavior with dynamic height constraints #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prateek-kalwar-95 wants to merge 0 commits into from
Closed

style: improve bottom sheet keyboard behavior with dynamic height constraints #535

prateek-kalwar-95 wants to merge 0 commits into from

Conversation

@prateek-kalwar-95
Copy link
Contributor

@prateek-kalwar-95 prateek-kalwar-95 commented Dec 25, 2025 •
edited
Loading

Description

  • Add dynamic height calculation based on keyboard visibility
  • Limit bottom sheet to 80% screen height when keyboard is closed
  • Adjust to remaining space (minus 100px top margin) when keyboard opens
  • Add BouncingScrollPhysics for smoother scrolling experience
  • Keep header fixed and visible at all times
  • Enable comfortable scrolling through form fields while typing

Fixes #(#534)

Screenshots

Befor->

before

After->

after

Checklist

  • [] Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Mastermind-sap
Mastermind-sap suggested changes Dec 25, 2025
View reviewed changes
@prateek-kalwar-95 prateek-kalwar-95 mentioned this pull request Dec 26, 2025
Closed
@SGI-CAPP-AT2 SGI-CAPP-AT2 mentioned this pull request Dec 27, 2025
Merged
4 tasks
@prateek-kalwar-95 prateek-kalwar-95 force-pushed the main branch 2 times, most recently from 50ff8c0 to b0596a2 Compare December 27, 2025 18:21
@prateek-kalwar-95
Copy link
Contributor Author

prateek-kalwar-95 commented Dec 28, 2025

@SGI-CAPP-AT2 can you check this pr

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Dec 28, 2025

@SGI-CAPP-AT2 can you check this pr

This PR have commits from the PR we merged for settings ui.

Can you please discard those also always create branches from main branch.
So you can avoid this.

No need to merge branch which is merged instead rebase with main.

@CCExtractor CCExtractor locked and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Mastermind-sap Mastermind-sap Awaiting requested review from Mastermind-sap

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prateek-kalwar-95 @SGI-CAPP-AT2 @Mastermind-sap