Covert all uses of Submit Nodes to Groups#20
Open
mattriggle05 wants to merge 12 commits into
Open
Conversation
mattriggle05
force-pushed
the
feature/submit-node-login-groups
branch
from
9a195a9 to
344eb45
Compare
mattriggle05
changed the title
Author
|
MUST be merged at the same time as CHTC/chtc-user-ui#71 |
CannonLock
requested changes
Jun 16, 2026
CannonLock
left a comment
CannonLock
left a comment
Member
There was a problem hiding this comment.
@mattriggle05 Can you run through this and handle the TODOs.
I am pro deleting everything that isn't being used anymore as it is just fine checking git history/blame if I need to do some git archeology. Explicitly I would go through and delete the pieces that can get deleted here and remove the TODO comments.
Comment on lines
+7
to
+8
| # TODO: Remove this — submit nodes replaced by SUBMIT_NODE groups | ||
| # from .submit_nodes import router as submit_nodes_router |
Member
There was a problem hiding this comment.
Can you clean up the TODOs. LMK if there is a reason to push these of for another section of work.
Author
There was a problem hiding this comment.
Doen and double checked, onyl remaining refernce to old submit nodes is int he old migrate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API side of issue #16