Update solve and solveAll with typehints #775
Conversation
IgnaceBleukx
changed the title
.solve() functions with type arguments.solve() functions with typed arguments
ThomSerg
left a comment
ThomSerg
left a comment
There was a problem hiding this comment.
Looks good. Maybe change the pull request's title to reflect that this is only for the time_limit argument, and for the others (for example not for solution_limit).
IgnaceBleukx
changed the title
.solve() functions with typed arguments.solve() functions with typed time_limit argument
Dimosts
left a comment
Dimosts
left a comment
There was a problem hiding this comment.
Why only time_limit and not e.g. also solution_limit? I suggest that we should do all that w can in the PR.
|
I updated the other common arguments to the solve/solveall functions, as well as the solution hint function. It's out of scope for this PR to fix it, but maybe @hbierlee could have a look at this in the future? This one should be ready for a re-review. |
tias
left a comment
tias
left a comment
There was a problem hiding this comment.
looks good to me, please keep the ball rolling
IgnaceBleukx
changed the title
.solve() functions with typed time_limit argument
|
Assuming the tests pass, I think this can be merged now |
Update the function headers of
solveandsolveAllwith type hints for the time_limit argument.Something weird was the
def solve()function of the superclass, it has some weirdmodelargument which did not make any sense to me; according to git blame it has been there since 2021.Also fixes #745 (new version of gcs)