Skip to content

fix gcc compiler errors when building on linux - #103

Closed
robmtud wants to merge 2 commits into
CSHS-CWRA:mainfrom
robmtud:robmtud/linux_fix_gcc_errors
Closed

robmtud wants to merge 2 commits into
CSHS-CWRA:mainfrom
robmtud:robmtud/linux_fix_gcc_errors

Conversation

@robmtud

@robmtud robmtud commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Currently under linux compilation will fail when using gcc. The following changes were made to address the gcc compiler errors:

  • move function definition from header to source file for 'bmi_model_create' and 'bmi_model_destroy'
  • use correct enum type for unrecognized forcing types
  • rename 'sv_type' attribute on 'rvn_var_data' struct to 'state_var_type' to not conflict with enum name

- move function definition from header to source file for
  'bmi_model_create' and 'bmi_model_destroy'
- use correct enum type for unrecognized forcing types
- rename 'sv_type' attribute on 'rvn_var_data' struct to
  'state_var_type' to not conflict with enum name
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.md and .zenodo.json:

  • The relevant author information has been added to AUTHORS.md and .zenodo.json

We also require that you sign our Contributor License Agreement before we can merge your code.
Please add the following line to your Pull Request description:

  • I have read and agree to the terms of the Contributor License Agreement.

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@robmtud robmtud closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants