Repository navigation
BMI GetValue: use actual gridsize in memcpy - #106
Merged
analytophile merged 3 commits intoAug 19, 2026
Merged
Conversation
This uses 'CRavenBMI::GetVarNbytes' to determine the output buffer size in the 'memcpy' call to write the ouput values. Previously a call to 'CModel::GetNumHRUs' was used to determine the grid size of the output variable. In the case that the number of HRUs is larger than the number of sub basins this can cause a segmenation fault if GetValue is called with an output buffer allocated for a variable on the sub basin grid.
for more information, see https://pre-commit.ci
analytophile
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
CRavenBMI::GetVarNbytesto determine the output buffer size in thememcpycall to write the ouput values.Previously a call to
CModel::GetNumHRUswas used to determine the grid size of the output variable. In the case that the number of HRUs is larger than the number of sub basins this can cause a segmenation fault ifGetValueis called with an output buffer allocated for a variable on the sub basin grid.Additionally the different calls to either
CModel::GetNumSubBasinsorCModel::GetNumHRUsin this function have been replaced with a call toCRavenBMI::GetGridSize(GetVarGrid(name))to simplify logic a bit.