Skip to content

Added SUBDAILY_HOURLY_MELT option - #114

Merged
analytophile merged 4 commits into
CSHS-CWRA:mainfrom
bergjus94:hourly-melt
Oct 8, 2026
Merged

analytophile merged 4 commits into
CSHS-CWRA:mainfrom
bergjus94:hourly-melt

Conversation

@bergjus94

Copy link
Copy Markdown
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Adds a new :SubdailyMethod SUBDAILY_HOURLY_MELT
This methods acts like a wrapper for the potential melt calculations. It disaggregates daily Tmin and Tmax into hourly values and then calculates potential melt for each hour with the currently chosen :PotentialMeltMethod. Potential melt for each hour is summed up and then averaged over 24h (negative hourly values are set to 0). This value is then the daily potential melt, which will be used for in the rest of the modelling chain.

Edits:
new subdaily method SUBDAILY_HOURLY_MELT (RavenInclude.h)
parsing of :SubdailyMethod SUBDAILY_HOURLY_MELT (ParseInput.cpp)
new function CModel::EstimatePotentialMeltFromSubdaily (Model.h, PotentialMelt.cpp)
added SUBDAILY_HOURLY_MELT to subdaily parameter check (ModelParamCheck.cpp)

Does this PR introduce a breaking change?

No

Other information:

I can also send the necessary edits for the Raven Manual again
Open question:
The hourly wrapper should probably not work for all :PotentialMeltMethod, which it does at the moment. Restrict to temperature index methods?

new subdaily method SUBDAILY_HOURLY_MELT (RavenInclude.h)
parsing of :SubdailyMethod SUBDAILY_HOURLY_MELT (ParseInput.cpp)
new function CModel::EstimatePotentialMeltFromSubdaily (Model.h, PotentialMelt.cpp)
added SUBDAILY_HOURLY_MELT to subdaily parameter check (ModelParamCheck.cpp)
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.md and .zenodo.json:

  • The relevant author information has been added to AUTHORS.md and .zenodo.json

We also require that you sign our Contributor License Agreement before we can merge your code.
Please add the following line to your Pull Request description:

  • I have read and agree to the terms of the Contributor License Agreement.

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@analytophile analytophile left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@analytophile
analytophile merged commit 66d3050 into CSHS-CWRA:main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants