Repository navigation
CaYaDev MilkDrop Presets: layout, embedding and the first five (#825) - #826
Merged
Merged
Conversation
…825) Adds presets/cayadev (CC BY 4.0, attribution "CaYaDev") with Neon Monsoon, Event Horizon, Prism Lattice, Northern Veil and Twelve Moons (MilkDrop 3). scripts/preset-pack.js embeds the folder as src/shared/presets-milkdrop-pack.js, which presets-milkdrop.js appends to the built-in list; it also builds the release zip, now in the release asset list. English descriptions come from pack.json through i18n. Each preset was checked: warp and comp shaders, 90 s on looped music without fade-out, white-out or freeze, 12-13.5 ms per 1080p frame on a Radeon 610M, the same brightness at 60 and 144 Hz, and (MilkDrop 2 presets) the same picture in BeatDrop. Tests enforce the two MilkDrop 2 rules that comparison caught: aspectx/aspecty are not visible to wave and shape code, and prefixed noise samplers must be declared in the shader. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
The embedded copy and the test compare the exact bytes; with autocrlf the files were stored with LF and an Ubuntu checkout would not match. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
) MilkDrop 2 #defines its inputs (time, bass, q1..q32, and per stage rad, ang, uv, uv_orig, hue_shader), so a variable with one of those names fails to compile there; PSVERSION 3 means ps_2_x, which has no dynamic break. Both were caught by compiling the presets the way MilkDrop does. The generated pack file carries the pack's CC BY 4.0 header instead of the MIT one, and the embedded-copy check ignores CRLF from Windows checkouts. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #825. Adds the layout for the CaYaDev MilkDrop Presets and the first five presets.
What
presets/cayadev/: the.milkfiles,pack.json(id, category, TR/EN description, MD3 flag),LICENSE.md(CC BY 4.0, attribution "CaYaDev") and a README listing the checks.scripts/preset-pack.js:src/shared/presets-milkdrop-pack.js, whichpresets-milkdrop.jsappends to the built-in list (all four pages load it first);--checkreports drift;--zipbuildsCaYaDev-MilkDrop-Presets-<version>.zipfor the release, now listed inscripts/release-assets.js.pack.jsonvia i18n..gitattributes: the.milkfiles are kept byte-exact (CRLF) on every OS.Presets
Neon Monsoon (liquid), Event Horizon (tunnel), Prism Lattice (geometric), Northern Veil (ambient scene), Twelve Moons (MilkDrop 3; an MD2 player shows four of the moons).
Checked
q30 = 60/fps.Tests
tests/preset-pack.test.js:aspectx/aspectyin wave/shape code (MD2 doesn't pass them there);src/main/zip-reader.js.Existing tests now exclude the pack where they describe the original five, and accept MD3 slots for MD3 presets. 3507 tests pass.