bugfix: trim xml import payload value before emptiness check

[somethingwithproof]

Summary

• fix XML import payload checks to trim the request value instead of trimming a boolean expression
• apply the correction in alert, report, and removal import handlers
• add regression test covering all three handlers
• update changelog with issue bug: import XML text emptiness check trims boolean instead of payload #269

Fixes #269

Validation

• php -l syslog_alerts.php
• php -l syslog_reports.php
• php -l syslog_removal.php
• php -l tests/regression/issue269_import_text_trim_check_test.php
• php tests/regression/issue269_import_text_trim_check_test.php

[Copilot]

Pull request overview

Fixes a long-standing operator-precedence bug in the Syslog plugin’s XML import handlers so that whitespace-only import_text payloads are treated as empty (instead of incorrectly passing the check), and adds a regression test plus changelog entry for issue #269.

Changes:

• Corrected the import_text emptiness check to trim the request value before comparing in alert/report/removal import handlers.
• Added a regression script to detect reintroduction of the legacy buggy pattern across the three handlers.
• Updated the changelog to note issue #269.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
syslog_alerts.php	Fixes the import_text trim/compare condition in alert_import()
syslog_reports.php	Fixes the import_text trim/compare condition in report_import()
syslog_removal.php	Fixes the import_text trim/compare condition in removal_import()
tests/regression/issue269_import_text_trim_check_test.php	Adds a regression check to ensure the legacy buggy pattern is not present
CHANGELOG.md	Documents issue #269 in the develop section

[somethingwithproof]

Fixed -- get_nfilter_request_var('import_text') is now called once, stored in $import_text, and reused for both the trim check and $xml_data assignment.

[TheWitness]

More merge conflicts.

[TheWitness]

We use only print, not echo. This may not pass the phpcsfixer. Let's see.