Open
Conversation
Add test for chamfer
Add test for chamfer
# Conflicts: # tests/test_chamfer.py
Member
|
Thanks for the PR, but looks like you still fail on mypy (annotations) and call |
Member
|
@kolod do you intend to work on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #786 Asymmetric Chamfer Error
cadquery uses random edge face when call into chamfer_builder.Add()
Fix uses face on which edge selected in chamfer_builder.Add() call
Example:
If both faces of the edge are selected chamfer now uses length2 for length to prevent unexpected behavior.
Example: