Skip to content

Closes #786 Asymmetric Chamfer Error#1579

Open
kolod wants to merge 4 commits intoCadQuery:masterfrom
kolod:fix_chamfer
Open

Closes #786 Asymmetric Chamfer Error#1579
kolod wants to merge 4 commits intoCadQuery:masterfrom
kolod:fix_chamfer

Conversation

@kolod
Copy link

@kolod kolod commented May 1, 2024

Closes #786 Asymmetric Chamfer Error

cadquery uses random edge face when call into chamfer_builder.Add()

Fix uses face on which edge selected in chamfer_builder.Add() call

Example:

Workplane().box(10, 10, 10).faces("<X").chamfer(1, 2)

image

If both faces of the edge are selected chamfer now uses length2 for length to prevent unexpected behavior.

Example:

Workplane().box(10, 10, 10).faces("<Y or <X").edges("|Z").chamfer(1, 2)

image

@kolod kolod changed the title fix #786 Asymmetric Chamfer Error Closes #786 Asymmetric Chamfer Error May 1, 2024
@adam-urbanczyk
Copy link
Member

Thanks for the PR, but looks like you still fail on mypy (annotations) and call show from the test which causes an error on azure. We'll probably need to discuss the proposed semantics too.

@adam-urbanczyk
Copy link
Member

@kolod do you intend to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asymmetric Chamfer Error

2 participants