feat: Tree traversal based initialization for assembly solving#1890
Draft
lenianiva wants to merge 10 commits intoCadQuery:masterfrom
Draft
feat: Tree traversal based initialization for assembly solving#1890lenianiva wants to merge 10 commits intoCadQuery:masterfrom
lenianiva wants to merge 10 commits intoCadQuery:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1868
This PR adds an optional initializer, which traverses through the constraint graph and locally solves every constraint with no degree of freedom. The traversal starts at fixed constraints. This provides a starting point for the solver to work with. If the constraint graph is a forest in which each tree has at most one fixed root, and each constraint has zero degree of freedom (e.g. axis with degree 0 or 180, or point), then this solves the constraints exactly.
Try this out:
with
tree_initialize, the number of iteration drops from 11 to (...)