82 warn when a tables explicit column widths sum wider than the available page width - #85
Merged
Cadons merged 5 commits intoAug 16, 2026
Conversation
Mirrors the existing vertical page-bottom overflow warning (#71): a table whose explicit column widths sum wider than the available width previously overflowed the page margin silently. resolve_table_column_widths already computes available_width and the fixed-column shortfall, so detect the overage there and log it instead of just clamping it away. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kCellPaddingX is a per-cell content inset already folded into every cell's own measured_size (and therefore into each column's natural width), but resolve_table_column_widths (and the matching wrap-budget estimate in Measure) additionally subtracted 2*kCellPaddingX from available_width as if it were a table-wide margin like table.padding(). That extra 5pt was never reintroduced anywhere, so a width-constrained table always rendered 5pt narrower than its available width -- and since the table is positioned flush against the container's leading edge, the missing width showed up entirely as a gap on the table's trailing (right) edge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-sum-wider-than-the-available-page-width # Conflicts: # docraft/src/docraft/loom/pipeline/docraft_loom_layout_processor.cc # docraft/src/docraft/loom/pipeline/docraft_loom_measure_processor.cc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.