Feature/private audit commitments#906
Merged
Calebux merged 2 commits intoJun 24, 2026
Merged
Conversation
added 2 commits
June 24, 2026 13:21
Add cryptographic commitment-based audit logging system that replaces plaintext on-chain logs while enabling selective disclosure. Architecture & Design (Phase 1): - Comprehensive security analysis and threat model - Hash-based commitments using SHA-256 (Pedersen rejected for Soroban) - Commitment formula: SHA256(event_data || blinding_factor || domain_sep) - 75% storage reduction (48 bytes vs 200+ bytes per log) - Security: 128-bit quantum, 256-bit classical resistance Soroban Contract (Phase 2): - Add record_commitment() for privacy-preserving logging - Add Merkle tree anchoring and verification functions - Maintain backward compatibility with legacy logging - Remove sub_id from on-chain storage (prevents linkage) - All tests passing (19/19) Client Library (Phase 3): - Implement AuditDisclosureClient for selective disclosure - Add commitment computation and verification - Add Merkle proof generation/verification interfaces - Add disclosure package format with user-friendly reports Database Schema: - Create commitment_blinding_factors table - Store encrypted 32-byte blinding factors - RLS policies for user privacy - Unique constraints on commitment_hash and commitment_index Documentation: - 90-page architecture review - Security analysis with threat model - Implementation progress tracker Next: Backend integration with commitment generation and encryption Related: #XXX
|
@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #827
Description
Test Plan
Checklist