Skip to content

Replace Scryfall's API with custom API using Scryfall data #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eradev wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Replace Scryfall's API with custom API using Scryfall data #11093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions forge-core/src/main/java/forge/util/ImageUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public static String getScryfallDownloadUrl(PaperCard cp, String face, String se
cardCollectorNumber = cardCollectorNumber.substring(0, cardCollectorNumber.length() - 1);
}

return String.format("%s/%s/%s?format=image&version=%s%s", editionCode, encodeUtf8(cardCollectorNumber),
return String.format("%s/%s/%s?version=%s%s", editionCode, encodeUtf8(cardCollectorNumber),
langCode, versionParam, faceParam);
}

Expand All @@ -270,7 +270,7 @@ public static String getScryfallTokenDownloadUrl(String collectorNumber, String
faceParam = "&face=back";
collectorNumber = collectorNumber.substring(0, collectorNumber.length() - 1);
}
return String.format("%s/%s/%s?format=image&version=%s%s", setCode, encodeUtf8(collectorNumber),
return String.format("%s/%s/%s?version=%s%s", setCode, encodeUtf8(collectorNumber),
langCode, versionParam, faceParam);
}

Expand Down
1 change: 0 additions & 1 deletion forge-gui/src/main/java/forge/gui/download/GuiDownloadPicturesHQ.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ private void addDLObject(final PaperCard c, final String face) {
String scryfallurl = ForgeConstants.URL_PIC_SCRYFALL_DOWNLOAD + "named?fuzzy=" + cardname;
if(!setCode.equals(CardEdition.UNKNOWN_CODE)) scryfallurl += "&set=" + setCode.toLowerCase();
if(face.equals("back")) scryfallurl += "&face=back";
scryfallurl += "&format=image";

downloads.put(destPath, scryfallurl);
}
Expand Down
2 changes: 1 addition & 1 deletion forge-gui/src/main/java/forge/localinstance/properties/ForgeConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ public final class ForgeConstants {
public static final String URL_PIC_DOWNLOAD = URL_CARDFORGE + "/images/cards/";
public static final String URL_TOKEN_DOWNLOAD = URL_CARDFORGE + "/images/tokens/";
public static final String URL_PRICE_DOWNLOAD = GITHUB_ASSETS_BASE + "all-prices.txt";
private static final String URL_SCRYFALL = "https://api.scryfall.com";
private static final String URL_SCRYFALL = "https://card-forge.net/api/v1";
public static final String URL_PIC_SCRYFALL_DOWNLOAD = URL_SCRYFALL + "/cards/";

// Constants for Display Card Identity game setting
Expand Down
Loading