Skip to content

[pull] master from MusicPlayerDaemon:master#62

Merged
pull[bot] merged 8 commits intoCartoonFan:masterfrom
MusicPlayerDaemon:master
Mar 11, 2026
Merged

[pull] master from MusicPlayerDaemon:master#62
pull[bot] merged 8 commits intoCartoonFan:masterfrom
MusicPlayerDaemon:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Mar 11, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

slqy123 and others added 8 commits March 2, 2026 21:22
Remove incorrect `* 1000` multiplier in fail_timer.Check() call.

When the PeriodClock API was migrated to std::chrono in commit 4011899
, the fail_timer.Check() call was not updated. This caused the timer
to check for a duration that was 1000 times longer than intended.
Fixes out-of-bounds read due to improper use of memcmp() and makes the
code simpler.

Similar to commit 8925cc1
A while ago, #2363 was
reported ("State file not saved to file when mpd is started and
stopped with systemd").  The root cause was that `libopenblas` creates
worker threads before MPD's main() is invoked, and these worker
threads do not have a proper signal block mask, therefore they receive
SIGTERM and this will unconditionally terminate MPD without proper
shutdown, leading to data loss.

This kind of library behavior implemented by libopenmpt is
unacceptable, and to prevent more bad surprises like this, MPD now
refuses to start when linked with such a library.  It aborts startup
when it sees that threads have already been created outside of its
control.
release v0.24.9
@pull pull bot locked and limited conversation to collaborators Mar 11, 2026
@pull pull bot added the ⤵️ pull label Mar 11, 2026
@pull pull bot merged commit 7d81cd4 into CartoonFan:master Mar 11, 2026
1 check was pending
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants