[pull] master from MusicPlayerDaemon:master#64
Merged
pull[bot] merged 21 commits intoCartoonFan:masterfrom Mar 19, 2026
Merged
Conversation
On Windows, the zlib CMakeLists.txt builds libzs.a but its pkg-config file, but the pkg-config file still contains "-lz". This is obviously broken. This adds a quilt patch that disables this madness.
ABIbreak in 1.14.26 has been reverted w/ 1.14.30, reapplied in 1.18.X align with upstream versions and make easier packaging. Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
It is unlikely that anybody ever uses such a long username or password, but if somebody does, they won't be happy about the silent truncation.
Same as in OnData() and OnError().
curl_version_info() is guaranteed to never return nullptr.
At this point, we have already checked that xfade_state is UNKNOWN.
This allows obtaining the error condition without having to rethrow it. The only caller in the player thread converts it back to a std::exception_ptr anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )