feat: unify error detection helpers across non-streaming handlers#8
Open
eli-bot-agent wants to merge 1 commit into
Open
feat: unify error detection helpers across non-streaming handlers#8eli-bot-agent wants to merge 1 commit into
eli-bot-agent wants to merge 1 commit into
Conversation
Extract detect_error_response() and extract_error_info() helpers in
error_handling.py to replace the duplicated _is_error_response() method
in OpenAINonStreamingHandler.
- detect_error_response(): handles both OpenAI-style {msg} and
Anthropic-style {error: {...}} error structures
- extract_error_info(): extracts (message, code) tuple from error
responses with consistent handling across formats
- Removes 3-line _is_error_response() helper from OpenAINonStreamingHandler
and eliminates copy-paste code in error handling logic
All 529 tests pass, coverage: 59% (untouched modules excluded).
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract
detect_error_response()andextract_error_info()helpers inerror_handling.pyto replace the duplicated_is_error_response()methodin
OpenAINonStreamingHandler.Changes
detect_error_response(): handles both OpenAI-style{msg}andAnthropic-style
{error: {...}}error structuresextract_error_info(): extracts(message, code)tuple from errorresponses with consistent handling across formats
_is_error_response()helper from OpenAINonStreamingHandlerTests
All 529 tests pass (7 skipped, 1 xfailed).