Conversation
Yes, the below approach will be a intended/correct approach.
python-chebai-graph/chebai_graph/preprocessing/properties/base.py Lines 156 to 171 in 63216b4 |
…on-chebai-graph into feature/sdf-support
…ith custom method in fg rules
Add support for the SDF-based dataset (ChEB-AI/python-chebai#147). This includes mostly:
Chem.Molobjects as input to_read_datafunctionsChem.Molas input toread_property(also: the_read_datafunction now returns the augmented molecule dictionary which gets passed toread_property, avoiding a complete recalculation for each property)sanitize_moleculefunction to ensure consistent SMILES parsingOne issue I came across while testing this: The
AugAtomNumHsproperty (or any property inheriting theFrozenPropertyAlias) doesn't allow new tokens to be created. @aditya0by0 How should I add new tokens here? Should I first build a dataset with the non-augmented version of each property and then use those to created an augmented dataset?