perf(onchain): replace locked Map with per-token instance storage#352
Open
ifygreg01-best wants to merge 1 commit into
Open
perf(onchain): replace locked Map with per-token instance storage#352ifygreg01-best wants to merge 1 commit into
ifygreg01-best wants to merge 1 commit into
Conversation
Switch TotalLocked from a single Map<Address, i128> cell to a typed contracttype enum key — TotalLocked::Token(Address) — so each token's locked amount occupies its own instance-storage cell. Previously, every decrement_locked call (claim, disburse, revoke, cancel_package, refund) deserialised the entire map, mutated one entry, and re-serialised the whole map — an O(N) ratchet that grew with the number of distinct tokens. Each create_package and batch_create_packages also performed the same full read/write inline. Changes: - Add TotalLocked contracttype enum (Token(Address) variant) - Add get_locked / set_locked private helpers (single-cell O(1) read/write) - Remove KEY_TOTAL_LOCKED constant (no longer needed) - Update all 7 sites: create_package, batch_create_packages, decrement_locked, get_total_locked, withdraw_surplus - batch_create_packages retains its single read-before/write-after pattern, preserving atomic batch accounting and eliminating the reentrancy window where intermediate locked values were visible - Regenerate test snapshots to reflect new storage key layout All 106 tests pass unchanged (aid_escrow_tests, gas_profiling, integration, batch, boundary, e2e, events, versioning, invariants).
Contributor
|
👋 Thanks for the contribution! This PR contains code/test changes and CI workflows were never auto-triggered (a GitHub Actions safety requirement for cross-repo forks). To unblock this for merging, a maintainer needs to either:\n\n1. Manually click 'Approve and run workflows' on this PR's Actions tab via the GitHub UI, or\n2. Approve the pending CI on the PR checks page.\n\nOnce the CI checks pass, this can be merged. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch TotalLocked from a single Map<Address, i128> cell to a typed contracttype enum key — TotalLocked::Token(Address) — so each token's locked amount occupies its own instance-storage cell.
Previously, every decrement_locked call (claim, disburse, revoke, cancel_package, refund) deserialised the entire map, mutated one entry, and re-serialised the whole map — an O(N) ratchet that grew with the number of distinct tokens. Each create_package and batch_create_packages also performed the same full read/write inline.
Changes:
All 106 tests pass unchanged (aid_escrow_tests, gas_profiling, integration, batch, boundary, e2e, events, versioning, invariants).
Summary
Testing
Screenshots
Checklist
closes perf(onchain): replace locked Map with per-token instance storage #352