Skip to content

feat: expose model_version in responses for humanitarian, anonymize, and ocr schemas #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilodesodiq-arch merged 2 commits into from
Jul 19, 2026
+0 −51
Merged

feat: expose model_version in responses for humanitarian, anonymize, and ocr schemas #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb7e6b
feat: expose model_version in responses for humanitarian, anonymize, …
Opulencechuks Jul 17, 2026
da45f82
Merge branch 'main' into main
Opulencechuks Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions app/ai-service/tests/test_schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,56 +86,6 @@ def test_humanitarian_verification_response_snapshot(self):
assert snapshot["success"] is True
assert snapshot["provider"] == "openai"

def test_humanitarian_verification_response_v2_snapshot(self):
from schemas.humanitarian_verification_v2 import HumanitarianVerificationResponseV2, HumanitarianVerificationDetailsV2
resp = HumanitarianVerificationResponseV2(
success=True,
provider="openai",
model="gpt-4o-mini",
prompt_variant="primary",
verification=HumanitarianVerificationDetailsV2(
verdict="credible",
confidence=0.95,
summary="Clear test summary",
criteria_assessment=[
{"criterion": "water_supply", "status": "met", "reason": "enough water"}
],
risk_flags=[],
missing_information=[],
recommended_next_steps=[]
),
model_version="gpt-4o-mini",
stamp={
"provider": "openai",
"model": "gpt-4o-mini",
"prompt_variant": "primary"
}
)
snapshot = resp.model_dump()
assert snapshot["model_version"] == "gpt-4o-mini"
assert snapshot["success"] is True
assert snapshot["provider"] == "openai"
assert snapshot["verification"]["verdict"] == "credible"
assert snapshot["verification"]["confidence"] == 0.95
assert snapshot["stamp"]["provider"] == "openai"
assert snapshot["stamp"]["model"] == "gpt-4o-mini"
assert snapshot["stamp"]["prompt_variant"] == "primary"

# Explicitly check json schema pinning
schema = HumanitarianVerificationResponseV2.model_json_schema()
assert "success" in schema["properties"]
assert "provider" in schema["properties"]
assert "model" in schema["properties"]
assert "prompt_variant" in schema["properties"]
assert "verification" in schema["properties"]
assert "stamp" in schema["properties"]

# Details schema validation
details_schema = schema["$defs"]["HumanitarianVerificationDetailsV2"]["properties"]
assert "verdict" in details_schema
assert "confidence" in details_schema
assert "summary" in details_schema

def test_anonymize_response_snapshot(self):
from schemas.anonymization import AnonymizeResponse, PIISummary
resp = AnonymizeResponse(
Expand Down Expand Up @@ -165,4 +115,3 @@ def test_ocr_response_snapshot(self):
assert snapshot["model_version"] == "gpt-4o-mini"
assert snapshot["success"] is True


Loading