Repository navigation
Cache warming hardcodes limit: 20 instead of WARM_PAGE_LIMIT #248
Description
Problem
In src/cache/warmer.ts lines 4 and 16, WARM_PAGE_LIMIT is defined as 20, but line 16 uses a magic number 20 instead of the constant:
const WARM_PAGE_LIMIT = 20;
// ...
const landingPageQuery = { page: 1, limit: 20 }; // Should use WARM_PAGE_LIMITIf the warm page limit changes, this line would be missed.
Fix
Use the constant:
const landingPageQuery = { page: 1, limit: WARM_PAGE_LIMIT };Scope
src/cache/warmer.ts-- use constant
Acceptance Criteria
- Magic number replaced with constant
- Cache warming uses configured limit
- Existing tests pass
Technical Context
src/cache/warmer.ts:16-- hardcoded value
Activity
Marvellous805 commentedon Aug 30, 2026
@Marvellous805 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Marvellous805 to this issue.
emarkees commentedon Aug 30, 2026
@emarkees has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @emarkees to this issue.
unlimitedengineer commentedon Aug 30, 2026
@unlimitedengineer has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @unlimitedengineer to this issue.
drips-wave commentedon Aug 30, 2026
Congratulations, @unlimitedengineer! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.
🧑💻 @unlimitedengineer: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Aug 31, 2026
🎉 This issue has been marked as completed on GrantFox!
@unlimitedengineer's PR #441 was approved and merged by @DeFiVC.
🏆 @unlimitedengineer: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (796 total points). Track your full progress on GrantFox.
👏 Great work, @unlimitedengineer! Keep contributing to ChainLearnOfficial.
drips-wave commentedon Aug 31, 2026
This issue has been completed by @unlimitedengineer as part of the Stellar Wave Program's 8th Wave 🥳
😎 @unlimitedengineer: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
fix: replace magic number, dedup logger, add coverage script, validat…