Repository navigation
add smooth clamping operator - #47
Merged
Merged
Conversation
nmbader
requested review from
MatthewEai,
jkwashbourne,
jkwashbourne-oss and
samtkaplan
July 9, 2026 16:52
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 95.94% 95.73% -0.22%
==========================================
Files 40 41 +1
Lines 1086 1148 +62
==========================================
+ Hits 1042 1099 +57
- Misses 44 49 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jkwashbourne-oss
approved these changes
Jul 10, 2026
jkwashbourne-oss
left a comment
Member
There was a problem hiding this comment.
can you fix the coverage issue? might be missing a test?
Member
Author
|
no missing tests just miscounting from codecov that misses lines of loop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JopClampC1: smooth bounded projection operatorThis PR adds
JopClampC1, a nonlinear Jet operator for pointwise bounded projection with consistent forward, Jacobian, and adjoint-Jacobian actions.[lo, hi]δ = transition * (hi - lo)near each bound, making the operatorC1Why this is useful:
The accompanying tests cover:
O(μ)andO(μ²)linearization rates in the smooth case,