Skip to content

Bspline boundary node contribution bugfix and kernel normalization - #50

Merged
nmbader merged 2 commits into
masterfrom
mbader/bspline-bugfix
Sep 30, 2026
Merged

nmbader merged 2 commits into
masterfrom
mbader/bspline-bugfix

Conversation

@nmbader

@nmbader nmbader commented Sep 30, 2026

Copy link
Copy Markdown
Member
  • Fix a bug in Bspline node contributions to the kernel caused by floor function rounding to the incorrect integer.
  • Add kernel normalization when irregular node spacing is used to ensure correct partition of unity
  • Add unit tests

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.64%. Comparing base (ca43190) to head (cf1b1f8).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   95.62%   95.64%   +0.01%     
==========================================
  Files          41       41              
  Lines        1120     1125       +5     
==========================================
+ Hits         1071     1076       +5     
  Misses         49       49              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmbader
nmbader merged commit 4652815 into master Sep 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants