Repository navigation
Make RTMP ping and ping_timeout configurable - #7846
Merged
Merged
Conversation
baptiste-bcn
force-pushed
the
feat-7719-rtmp-ping-config
branch
from
October 28, 2026 14:32
a7dcf0a to
eb59a7f
Compare
Contributor
Author
|
Hi @Chocobozzz, all checks are green after rebasing on the latest |
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RTMP keepalive interval (
ping) and dead-connection timeout (ping_timeout) were hardcoded inVIDEO_LIVE.RTMP(60s / 30s) and passed straight to node-media-server, so admins couldn't tune how fast a dead ingest connection frees the publisher slot.This PR exposes them in the
live.rtmpconfig block, with the current values as defaults (no behavior change unless overridden):Changes:
ping/ping_timeouttodefault.yamlandproduction.yaml.exampleconfig.tsas static keys (the RTMP server is configured once at startup) and add them to the config checklive-manager.tsinstead of the removedVIDEO_LIVE.RTMP.PING/PING_TIMEOUTconstantsPEERTUBE_LIVE_RTMP_PING/PEERTUBE_LIVE_RTMP_PING_TIMEOUTDocker environment variablesconfig-schema.jsonRelated issues
Fixes #7719
Has this been tested?
Build and lint pass.