Repository navigation
fix: group Node runtime updates in Renovate - #949
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe Node.js package rule now groups Node, npm, and listed official Node container image references. It enables the rule and combines major/minor and minor/patch updates. ChangesNode.js Update Grouping
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: 🔵 Low · up to Some grouped Node-image updates could bundle an npm version outside a consumer’s declared range, risking deployment failures. No specific incompatible update was confirmed, so this is a bounded compatibility risk rather than a demonstrated blocker. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Usage-based review receipt
Note This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing. Comment |
|
View your CI Pipeline Execution ↗ for commit f46b19f
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Summary
The shared preset disabled
nodeandnpmupdates but missed registry-qualified Node images. This let Renovate update template-nestjs's Docker image independently and break deployment withEBADENGINE.Replace that disable rule with one
Node.jsgroup covering Node version files, package engine requirements, npm, and official Node images from Docker Hub and ECR Public. Disable major/minor and minor/patch splitting within the group so the runtime updates use one branch. This enables Node/npm updates for repositories using this preset; existing release-age, schedule, and automerge rules still apply.Evidence
applyPackageRulespassed eight runtime fixtures:.nvmrc, Node/npm engines, and five official Docker name forms. All are enabled with group slugnodejs,separateMajorMinor=false, andseparateMinorPatch=false. The same harness verified the previous config disabled Node/npm while allowing the ECR image update.calico/node,kindest/node,@types/node, and Clipboard library fixtures are excluded; Nx remains disabled.npx --yes --package renovate@44.134.1 renovate-config-validator default.jsonvalidation passed using the installed validator. It reports the existingexcludePackageNamesmigration warning.oxfmt --check default.jsonandgit diff --checkpassed.Merge Danger
Door: two-way. Restore the prior rule to disable Node/npm updates again.
Blast radius: repositories extending
github>ClipboardHealth/core-utils. They will become eligible for grouped Node/npm updates. Existing consumers can override the group in their repository config.Agent session:
codex resume 01a1213d-2200-7972-b6c0-5cb447efc2f2· Model:gpt-6-1-sol· Reasoning:high🤖
cb-ship:created v1 skill@1.0.21