Skip to content

fix: group Node runtime updates in Renovate - #949

Merged
therockstorm merged 1 commit into
mainfrom
codex/group-node-runtime
Oct 9, 2026
Merged

therockstorm merged 1 commit into
mainfrom
codex/group-node-runtime

Conversation

@therockstorm

Copy link
Copy Markdown
Member

Summary

The shared preset disabled node and npm updates but missed registry-qualified Node images. This let Renovate update template-nestjs's Docker image independently and break deployment with EBADENGINE.

Replace that disable rule with one Node.js group covering Node version files, package engine requirements, npm, and official Node images from Docker Hub and ECR Public. Disable major/minor and minor/patch splitting within the group so the runtime updates use one branch. This enables Node/npm updates for repositories using this preset; existing release-age, schedule, and automerge rules still apply.

- node/npm updates disabled; ECR Node image updated independently
+ version files + engines + npm + official Node images: renovate/nodejs

Evidence

  • Before: template-nestjs deployment failure reports Docker Node 26.11.1/npm 11.20.0 versus required Node 26.4.0/npm ~11.17.0.
  • After: Renovate 44.134.1's actual applyPackageRules passed eight runtime fixtures: .nvmrc, Node/npm engines, and five official Docker name forms. All are enabled with group slug nodejs, separateMajorMinor=false, and separateMinorPatch=false. The same harness verified the previous config disabled Node/npm while allowing the ECR image update.
  • Unrelated calico/node, kindest/node, @types/node, and Clipboard library fixtures are excluded; Nx remains disabled.
  • npx --yes --package renovate@44.134.1 renovate-config-validator default.json validation passed using the installed validator. It reports the existing excludePackageNames migration warning.
  • oxfmt --check default.json and git diff --check passed.
  • Not run: live Renovate update generation across consumer repositories. Grouping collects available updates; it does not prove compatibility with the npm version bundled in each image.

Merge Danger

Door: two-way. Restore the prior rule to disable Node/npm updates again.

Blast radius: repositories extending github>ClipboardHealth/core-utils. They will become eligible for grouped Node/npm updates. Existing consumers can override the group in their repository config.

Agent session: codex resume 01a1213d-2200-7972-b6c0-5cb447efc2f2 · Model: gpt-6-1-sol · Reasoning: high

🤖 cb-ship:created v1 skill@1.0.21

@therockstorm therockstorm self-assigned this Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 40866177-d19c-4a8a-a354-e9ebc9fa48d2

📥 Commits

Reviewing files that changed from the base of the PR and between 7975ea2 and f46b19f.


📒 Files selected for processing (1)
  • default.json

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.



📝 Walkthrough

Walkthrough

The Node.js package rule now groups Node, npm, and listed official Node container image references. It enables the rule and combines major/minor and minor/patch updates.

Changes

Node.js Update Grouping

Layer / File(s) Summary
Configure the Node.js update group
default.json
The rule now covers Node, npm, and listed official Node image names. It enables grouped updates and combines major/minor and minor/patch updates.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes


Merge Risk: 🔵 Low · up to f46b1

Some grouped Node-image updates could bundle an npm version outside a consumer’s declared range, risking deployment failures. No specific incompatible update was confirmed, so this is a bounded compatibility risk rather than a demonstrated blocker.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the Renovate rule changes, their purpose, validation results, and impact on consuming repositories.
Title check Passed The title clearly and concisely identifies the main change: grouping Node runtime updates in Renovate.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.


Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f46b19f

Command Status Duration Result
nx affected --configuration ci --parallel 8 --t... ✅ Succeeded <1s View ↗
nx build ai-rules ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-09 15:30:34 UTC

@therockstorm
therockstorm merged commit eb5f458 into main Oct 9, 2026
6 checks passed
@therockstorm
therockstorm deleted the codex/group-node-runtime branch October 9, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant