Repository navigation
chore: remove ai-rules, replaced by engineering-practices - #951
Merged
Merged
Conversation
@clipboard-health/engineering-practices in ClipboardHealth/cbh-core (packages/engineering-practices) replaces @clipboard-health/ai-rules. Delete packages/ai-rules and every reference to it: CODEOWNERS (the file only covered this package), knip ignore, root README package list, tsconfig paths and references, and package-lock.json. Point the no-cross-contract-imports README at engineering-practices. Published ai-rules versions stay on npm for consumers that still pin them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (63)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (62)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe PR removes the Changesai-rules package removal
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to Removing the local package does not change this repository’s setup command, which already synced the replacement guidance. The updated REST API link resolves, and no actionable merge risk remains. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly states that the ai-rules package is being removed because engineering-practices replaces it. |
| Description check | |
The description directly explains the package retirement, reference cleanup, replacement package, validation evidence, and release impact. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
View your CI Pipeline Execution ↗ for commit 2de7d9e
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@clipboard-health/ai-rulesis replaced by@clipboard-health/engineering-practices(ClipboardHealth/cbh-core,packages/engineering-practices). This PR retires the old source in this repo.packages/ai-rules..github/CODEOWNERS(the file only covered this package, so it is deleted),.knip.jsoncignore, rootREADME.mdpackage list,tsconfig.base.jsonandtsconfig.lint.jsonpaths,tsconfig.jsonproject reference, andpackage-lock.json(workspace link and package entries).no-cross-contract-imports/README.mdatrules/backend/restApiDesign.mdin@clipboard-health/engineering-practices.packages/*glob.sync-ai-rulesscript name stays. It already runsengineering-practices-sync.Why
The rules now ship from
cbh-core. Keeping a second copy here invites drift and releases a package nobody should install.Evidence
Ran with Node from
.nvmrc:npm installregenerates a lockfile that only drops the two ai-rules entries, andpostinstallprints✅ @clipboard-health/engineering-practices synced common (18 rules).format:check,knip,markdown:lint,syncpack:lint,architecture:check,embed:check, andlintpass.nx build eslint-pluginpasses. Full typecheck is left to CI.git grep ai-rulesfinds only thesync-ai-rulesscript name and CHANGELOGs.Merge Danger
Low. Published
@clipboard-health/ai-rulesversions stay on npm (no deprecate or unpublish), so consumers that still pin a version keep installing.job-hunt-buddyandslatestill pin one and are being switched separately. The next release run will not publishai-rulesagain.🤖 Generated with Claude Code