Repository navigation
fix: sync engineering practices on prepare, not postinstall - #429
Conversation
groundcrew is published to npm, so postinstall ran the private sync in every consumer's install. npm runs prepare only for local installs, so contributors and CI still sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe package scripts no longer run ChangesInstall lifecycle
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The sync moves to Pre-merge checks |
|
Summary
#428 added
postinstall: node --run sync-ai-rules. groundcrew is published to public npm, so every consumer install would runnpm exec @clipboard-health/engineering-practices@latest: an E404 for most, and for anyone with a ClipboardNPM_TOKEN, it would write.rules/andAGENTS.mdintonode_modules/@clipboard-health/groundcrew. No release has shipped it yet.This moves the sync to
prepare, which npm runs for local installs (npm install,npm ci) but not when installing from the registry.Merge Danger
Two-way. Must merge before the next
feat:orfix:release.🤖 Generated with Claude Code