Don't use the type of checked TYPED-FORMs to rewrite acode#537
Open
se-mz wants to merge 1 commit intoClozure:masterfrom
Open
Don't use the type of checked TYPED-FORMs to rewrite acode#537se-mz wants to merge 1 commit intoClozure:masterfrom
se-mz wants to merge 1 commit intoClozure:masterfrom
Conversation
Optimizations that rely on ASSERTED-TYPE might change the value (hence type) of the inner form if it isn't actually of the given type, which would defeat the point of typechecking. This looks like it may hurt the performance of code that both trusts declarations and generates checked TYPED-FORMs, but at the time of writing, this can only happen when the user provides a compiler policy that has both TRUST-DECLARATIONS and DECLARATIONS-TYPECHECK enabled; in the default policy, they're mutually exclusive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizations that rely on ASSERTED-TYPE might change the value (hence type) of the inner form if it isn't actually of the given type, which would defeat the point of typechecking.
This looks like it may hurt the performance of code that both trusts declarations and generates checked TYPED-FORMs, but this can only happen when the user provides a compiler policy that has both TRUST-DECLARATIONS and DECLARATIONS-TYPECHECK enabled; in the default policy, they're mutually exclusive.
For an example of how this can cause issues, consider the following:
(the fixnum x)is necessary to make the acode rewriter for ASH trust that it's working on a fixnum and rewrite to %ILSL; on high safety, it won't trust the unchecked TYPED-FORM generated by the type declaration.