Merged
Conversation
danc094codetogether
approved these changes
Feb 5, 2025
Contributor
danc094codetogether
left a comment
danc094codetogether
left a comment
There was a problem hiding this comment.
Changes looks good.
patrick-codetogether
added a commit
that referenced
this pull request
Feb 12, 2025
* Change collab helm chart to use private registry image * Changes for docker compose. (#85) * Rename hq to intel * Allow user to provide their own hqproperties secret (#86) * allow users to provide their own hqproperties secret for improved security over sensitive information * PR feedback. cleaner value structure and using an explicit hqpropertiessecret.enabled value to toggle whether the secret is read --------- Co-authored-by: Ignacio Moreno <nmorenor@gmail.com> Co-authored-by: Ignacio Moreno <ignacio@codetogether.com>
nmorenor
added a commit
that referenced
this pull request
Feb 20, 2025
* Change collab helm chart to use private registry image * Changes for docker compose. (#85) * Rename hq to intel * Allow user to provide their own hqproperties secret (#86) * allow users to provide their own hqproperties secret for improved security over sensitive information * PR feedback. cleaner value structure and using an explicit hqpropertiessecret.enabled value to toggle whether the secret is read * fix intel secret provisioning (#91) --------- Co-authored-by: Ignacio Moreno <nmorenor@gmail.com> Co-authored-by: Ignacio Moreno <ignacio@codetogether.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3454