Skip to content

Set edit meal back button minimal - #1711

Closed
thorethy1 wants to merge 1 commit into
CodeWithCJ:mainfrom
thorethy1:codex/edit-logged-meal-minimal-back
Closed

Set edit meal back button minimal#1711
thorethy1 wants to merge 1 commit into
CodeWithCJ:mainfrom
thorethy1:codex/edit-logged-meal-minimal-back

Conversation

@thorethy1

@thorethy1 thorethy1 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Tip

Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run pnpm run validate to check for any errors.
PRs that include tests and clear screenshots are highly preferred!
Note: AI-generated descriptions must be manually edited for conciseness. Do not paste raw AI summaries.

Description

What problem does this PR solve?
(Keep it concise. 1–2 sentences.)

  • Set EditLoggedMeal to use headerBackButtonDisplayMode: 'minimal' explicitly.
  • Keeps the native header contract green without relying on native-stack default back-title behavior.

Why

The native header contract requires root-stack screens with a real iOS back button to explicitly choose either a stable headerBackTitle or headerBackButtonDisplayMode: 'minimal'. EditLoggedMeal can appear minimal in the app today, but that is implicit native-stack behavior and can vary with navigation context.

Follow-up

A larger navigation refactor could move tab-owned routes such as diary rows/details into their tab-local stacks. That would make back behavior more natural, reduce root-stack special cases, and improve maintainability. Should we plan that as a separate PR?

Validation

  • cd SparkyFitnessMobile && ./node_modules/.bin/jest --watchman=false --runInBand --coverage=false __tests__/navigation/nativeHeaderContract.test.ts
  • cd SparkyFitnessMobile && ./node_modules/.bin/eslint App.tsx --max-warnings 0
  • cd SparkyFitnessMobile && ./node_modules/.bin/tsc --noEmit

Linked Issue: #1675

PR Type

  • Issue (bug fix)
  • New Feature
  • Refactor
  • Documentation

Checklist

All PRs:

  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code, and I agree to the License terms.

New features only:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers or it was approved on Discord.

Frontend changes (SparkyFitnessFrontend/):

  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate and it passes.
  • [MANDATORY for Frontend changes] Translations: I have only updated the English (en) translation file.

Backend changes (SparkyFitnessServer/):

  • [MANDATORY for Backend changes] Code Quality: I have run typecheck, lint, and tests. New files use TypeScript, new endpoints have Zod schemas, and new endpoints include tests.
  • [MANDATORY for Backend changes] Database Security: I have updated rls_policies.sql for any new user-specific tables.

UI changes (components, screens, pages):

  • [MANDATORY for UI changes] Screenshots: I have attached Before/After screenshots below.

Mobile changes (SparkyFitnessMobile/):

  • [MANDATORY for Mobile changes] Tested on device or emulator: I have verified the changes work on iOS or Android.

@github-actions github-actions Bot added the mobile label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Validation Results

Change Detection

  • 📱 Mobile changes detected

✅ All checks passed. Thank you!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the navigation options for the EditLoggedMeal screen in SparkyFitnessMobile/App.tsx by replacing the headerBackTitle option with headerBackButtonDisplayMode set to 'minimal'. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions github-actions Bot added the bug Something isn't working label Jul 2, 2026
@thorethy1 thorethy1 closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant