Set edit meal back button minimal - #1711
Closed
thorethy1 wants to merge 1 commit into
Closed
Conversation
PR Validation ResultsChange Detection
✅ All checks passed. Thank you! |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the navigation options for the EditLoggedMeal screen in SparkyFitnessMobile/App.tsx by replacing the headerBackTitle option with headerBackButtonDisplayMode set to 'minimal'. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Note: AI-generated descriptions must be manually edited for conciseness. Do not paste raw AI summaries.
Description
What problem does this PR solve?
(Keep it concise. 1–2 sentences.)
EditLoggedMealto useheaderBackButtonDisplayMode: 'minimal'explicitly.Why
The native header contract requires root-stack screens with a real iOS back button to explicitly choose either a stable
headerBackTitleorheaderBackButtonDisplayMode: 'minimal'.EditLoggedMealcan appear minimal in the app today, but that is implicit native-stack behavior and can vary with navigation context.Follow-up
A larger navigation refactor could move tab-owned routes such as diary rows/details into their tab-local stacks. That would make back behavior more natural, reduce root-stack special cases, and improve maintainability. Should we plan that as a separate PR?
Validation
cd SparkyFitnessMobile && ./node_modules/.bin/jest --watchman=false --runInBand --coverage=false __tests__/navigation/nativeHeaderContract.test.tscd SparkyFitnessMobile && ./node_modules/.bin/eslint App.tsx --max-warnings 0cd SparkyFitnessMobile && ./node_modules/.bin/tsc --noEmitLinked Issue: #1675
PR Type
Checklist
All PRs:
New features only:
Frontend changes (
SparkyFitnessFrontend/):pnpm run validateand it passes.en) translation file.Backend changes (
SparkyFitnessServer/):rls_policies.sqlfor any new user-specific tables.UI changes (components, screens, pages):
Mobile changes (
SparkyFitnessMobile/):