Cape Town | 2026-ITP-Jan | Pretty Taruvinga | Sprint 2 | Structuring And Testing Data #1007
Open
Pretty548 wants to merge 8 commits intoCodeYourFuture:mainfrom
Open
Cape Town | 2026-ITP-Jan | Pretty Taruvinga | Sprint 2 | Structuring And Testing Data #1007Pretty548 wants to merge 8 commits intoCodeYourFuture:mainfrom
Pretty548 wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
added 7 commits
February 19, 2026 17:54
2. Turned the code 3. Declared the function
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pretty548
added
🏕 Priority Mandatory
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Pretty548
changed the title
Pretty548
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Mar 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one function you could improve a bit further
| function calculateBMI(weight, height) { | ||
| // return the BMI of someone based off their weight and height | ||
| const bmi = weight / (height * height); | ||
| return Math.round(bmi * 10) / 10; |
There was a problem hiding this comment.
Why do you multiply by 10 and then divide by 10? Is there an easier way to get 1 decimal place?
Author
There was a problem hiding this comment.
I multiplied by 10 and divided by 10 to round the BMI to one decimal place using Math.round(), since it only rounds whole numbers.
Alternatively, I could use Number(bmi.toFixed(1)) which is a bit cleaner and more readable.
There was a problem hiding this comment.
Good suggestion - I think toFixed makes more sense here. Can you make that change in the code?
Author
There was a problem hiding this comment.
Thanks for the feedback! I've updated the function to use toFixed(1) for rounding to one decimal place.
LonMcGregor
added
Reviewed
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this sprint I worked on JavaScript challenges focused on functions, arrays, and string manipulation. I wrote pure functions that return values so they can be tested and used unit tests to confirm my solutions work correctly.
I practiced key concepts like variable scope, avoiding variable shadowing, and using methods such as padStart for formatting. One issue I faced was redeclaring a variable inside a function, which I fixed by using the parameter instead.
This sprint improved my problem-solving skills and my confidence in debugging and writing cleaner, more readable code.