London | 25-ITP-May | Kayanat Suleman | Sprint 3 | Implement & Rewrite Tests#1020
Open
KayanatSuleman wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Conversation
KayanatSuleman
added
the
Needs Review
Open
10 tasks
KayanatSuleman
added
Module-Structuring-And-Testing-Data
This was referenced Feb 23, 2026
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Mar 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Your solutions are all working and good, but I have some suggestions for you to think about which could improve them further
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
LonMcGregor
added
Reviewed
KayanatSuleman
added
Needs Review
|
Good explanations for why you wrote the fractions function that way - thanks for updating the console.logs. This sprint task is complete now. |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented getAngleType, isProperFraction, and getCardValue solutions.
Rewrote tests using Jest to cover expected cases, including boundary/invalid inputs.